-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "inputSourceMap" for coverage re-mapping. #4009
Conversation
Use "inputSourceMap" instead of read from file. The "babel-plugin-istanbul" can use the input source map from "inputSourceMap" or "inlineSourceMap". The final source map from babel is not suitable for the coverage re-mapping. The "istanbul" will ignore the "inputSourceMap", if it already registered.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #4009 +/- ##
==========================================
- Coverage 60.26% 60.22% -0.05%
==========================================
Files 196 196
Lines 6765 6770 +5
Branches 6 6
==========================================
Hits 4077 4077
- Misses 2685 2690 +5
Partials 3 3
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Use "inputSourceMap" instead of read from file.
The "babel-plugin-istanbul" can use the input source map from "inputSourceMap" or "inlineSourceMap".
The final source map from babel is not suitable for the coverage re-mapping.
The "istanbul" will ignore the "inputSourceMap", if it already registered.