Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "inputSourceMap" for coverage re-mapping. #4009

Merged
merged 7 commits into from
Aug 24, 2017
Merged

Conversation

shenjunru
Copy link
Contributor

Summary

Use "inputSourceMap" instead of read from file.
The "babel-plugin-istanbul" can use the input source map from "inputSourceMap" or "inlineSourceMap".
The final source map from babel is not suitable for the coverage re-mapping.
The "istanbul" will ignore the "inputSourceMap", if it already registered.

Use "inputSourceMap" instead of read from file.
The "babel-plugin-istanbul" can use the input source map from "inputSourceMap" or "inlineSourceMap".
The final source map from babel is not suitable for the coverage re-mapping.
The "istanbul" will ignore the "inputSourceMap", if it already registered.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #4009 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
- Coverage   60.26%   60.22%   -0.05%     
==========================================
  Files         196      196              
  Lines        6765     6770       +5     
  Branches        6        6              
==========================================
  Hits         4077     4077              
- Misses       2685     2690       +5     
  Partials        3        3
Impacted Files Coverage Δ
...ckages/jest-cli/src/reporters/coverage_reporter.js 47.05% <0%> (-2.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e1a0a...4cb9415. Read the comment docs.

@cpojer cpojer merged commit 9c55f2b into jestjs:master Aug 24, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants