Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es5 build of pretty-format #4075

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Conversation

skovhus
Copy link
Contributor

@skovhus skovhus commented Jul 19, 2017

Summary

Fixes #4002

Test plan

I've added a simple integration tests.

@cpojer
Copy link
Member

cpojer commented Jul 19, 2017

Seems like this fails CI?

@pedrottimark
Copy link
Contributor

Thank you for following up. Was about to try, but better for me to watch and learn :)

@skovhus skovhus force-pushed the pretty-format-es5 branch 2 times, most recently from 876ddd6 to e19d0b0 Compare July 19, 2017 21:53
@@ -155,4 +155,4 @@ const print = (
return result;
};

module.exports = ({print, test}: Plugin);
export default ({print, test}: Plugin);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding both the default and named export we support both ES6 module consumers (like rollup) and CommonJS require use several places in Jest source code.

@skovhus
Copy link
Contributor Author

skovhus commented Jul 19, 2017

@cpojer hopefully CI should be happy again now.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e8ed43e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4075   +/-   ##
=========================================
  Coverage          ?   60.35%           
=========================================
  Files             ?      195           
  Lines             ?     6757           
  Branches          ?        6           
=========================================
  Hits              ?     4078           
  Misses            ?     2676           
  Partials          ?        3
Impacted Files Coverage Δ
...s/pretty-format/src/plugins/lib/print_immutable.js 100% <ø> (ø)
packages/pretty-format/src/plugins/convert_ansi.js 100% <ø> (ø)
...kages/pretty-format/src/plugins/lib/escape_html.js 100% <ø> (ø)
.../pretty-format/src/plugins/react_test_component.js 100% <100%> (ø)
...ackages/pretty-format/src/plugins/react_element.js 100% <100%> (ø)
...ackages/pretty-format/src/plugins/immutable_set.js 100% <100%> (ø)
...ckages/pretty-format/src/plugins/immutable_list.js 100% <100%> (ø)
...pretty-format/src/plugins/immutable_ordered_set.js 100% <100%> (ø)
...pretty-format/src/plugins/immutable_ordered_map.js 100% <100%> (ø)
...es/pretty-format/src/plugins/asymmetric_matcher.js 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ed43e...ab7feb0. Read the comment docs.

@cpojer cpojer merged commit c784bfa into jestjs:master Jul 20, 2017
@skovhus skovhus deleted the pretty-format-es5 branch July 20, 2017 12:31
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ES5 browser build for pretty-format
5 participants