Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--findRelatedFiles #4131

Merged
merged 1 commit into from
Jul 27, 2017
Merged

--findRelatedFiles #4131

merged 1 commit into from
Jul 27, 2017

Conversation

aaronabramov
Copy link
Contributor

is there a way to make flow complain when we try to access non-existing property of a strictly typed object?

in this case it was globalConfig.findRelatedTests call that always returned undefined since this property was missing in normalize.js

i'm not sure how it happened exactly, but it was probably me replacing hardcoded argv calls to globalConfig :(

@codecov-io
Copy link

Codecov Report

Merging #4131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4131   +/-   ##
=======================================
  Coverage   60.37%   60.37%           
=======================================
  Files         195      195           
  Lines        6768     6768           
  Branches        6        6           
=======================================
  Hits         4086     4086           
  Misses       2679     2679           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-config/src/index.js 0% <ø> (ø) ⬆️
packages/jest-config/src/normalize.js 81.08% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bd046...a36c2c3. Read the comment docs.

@cpojer cpojer merged commit be47f7b into jestjs:master Jul 27, 2017
@aaronabramov aaronabramov deleted the find_related_test branch July 27, 2017 17:18
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants