Add contextLines option to jest-diff
#4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jul 28, 2017
| ? contextLines | ||
| : 'null'} ${typeof contextLines !== 'number' || contextLines < 0 | ||
| ? '(5 default)' | ||
| : ''}`, () => { |
There was a problem hiding this comment.
Probably need to run prettier
There was a problem hiding this comment.
Nah, this is OK. But maybe we can make it more readable?
There was a problem hiding this comment.
Flow complains if I extract it and I did not simplify it because 0 is falsy too.
thymikee
reviewed
Jul 28, 2017
| _test(2); | ||
| _test(1); | ||
| _test(0); | ||
| _test(-1); // Will use default |
There was a problem hiding this comment.
Can we rename this function? E.g. testDiffContextLines()
thymikee
requested changes
Jul 28, 2017
thymikee
approved these changes
Jul 28, 2017
thymikee
changed the title
contextLines option to jest-diff
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Be able to define custom contextLines on jest-diff. * Naming changes into diff.test.js.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4147. This will be useful for libraries like https://github.com/thymikee/snapshot-diff.
Test plan
Added several test cases (with snapshots) in
diff.test.js.