Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace print with serialize in AsymmetricMatcher plugin #4173

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

pedrottimark
Copy link
Contributor

Summary

Please pace yourself, my friendly reviewer :)

  • Breaking change for edge case: ++depth > config.maxDepth like ordinary Array or Object
  • Replace opts.spacing === SPACE with config.min

Test plan

Added 2 fail-first tests for new result: maxDepth option

Additional tests explicitly specify existing correct results:

  • stringMatching(regexp) {escapeRegex: false}
  • stringMatching(regexp) {escapeRegex: true}
  • indent option

@codecov-io
Copy link

Codecov Report

Merging #4173 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4173      +/-   ##
==========================================
- Coverage   60.55%   60.53%   -0.02%     
==========================================
  Files         196      196              
  Lines        6776     6779       +3     
  Branches        6        6              
==========================================
+ Hits         4103     4104       +1     
- Misses       2670     2672       +2     
  Partials        3        3
Impacted Files Coverage Δ
...es/pretty-format/src/plugins/asymmetric_matcher.js 90% <80%> (-10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9665de2...c6a156c. Read the comment docs.

@cpojer cpojer merged commit ca366b5 into jestjs:master Aug 1, 2017
@pedrottimark pedrottimark deleted the asymmetric-matcher-serialize branch August 1, 2017 21:22
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants