-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split TestRunner off of TestScheduler #4233
Conversation
this._dispatcher = new ReporterDispatcher(); | ||
this._globalConfig = globalConfig; | ||
this._testRunner = new TestRunner(globalConfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like TestRunner doesn't even need a state, we can do
import {runTests} from './test_runner';
// ...
runTests(globalConfig, ...restOfArguments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is temporary and will change very soon.
Codecov Report
@@ Coverage Diff @@
## master #4233 +/- ##
==========================================
- Coverage 60.13% 60.12% -0.02%
==========================================
Files 191 192 +1
Lines 6756 6761 +5
Branches 6 6
==========================================
+ Hits 4063 4065 +2
- Misses 2690 2693 +3
Partials 3 3
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Second step in making test runners pluggable. This simply splits up the big scheduler class into the TestScheduler that instruments everything and a concrete TestRunner that knows how to schedule JavaScript tests.
Test plan
jest