Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide with jest-codemods transformers #4306

Merged
merged 3 commits into from
Aug 20, 2017

Conversation

skovhus
Copy link
Contributor

@skovhus skovhus commented Aug 20, 2017

Summary

The migration-guide documentation hasn't been updated for some time and jest-codemods now supports upgrading from even more test frameworks to Jest.

Test plan

Before:
screenshot 2017-08-20 18 47 47

After:
screenshot 2017-08-20 18 47 32

@skovhus
Copy link
Contributor Author

skovhus commented Aug 20, 2017

Error: Cannot find module 'jest-runner'

Hm. What is going on... Seems the latest 6 PRs have the same issue. Maybe jest-runner should be published again to npm @cpojer

Looks a bit funky https://www.npmjs.com/package/jest-runner

@thymikee
Copy link
Collaborator

@skovhus this is known issue for some time. Looks like a bug with yarn workspaces linking, didn't have time to investigate it though.

@skovhus
Copy link
Contributor Author

skovhus commented Aug 20, 2017

@thymikee ok, thanks.

packages/jest-cli/package.json contains a "jest-runner": "^20.0.4" and npm info jest-runner gives me:

{ name: 'jest-runner',
  'dist-tags': { latest: '0.0.0', test: '21.0.0-alpha.1' },
  versions: [ '0.0.0', '21.0.0-alpha.1' ],
  maintainers: [ 'cpojer <christoph.pojer@gmail.com>' ],
  time: 
   { modified: '2017-08-11T10:14:36.226Z',
     created: '2017-08-10T13:06:20.442Z',
     '0.0.0': '2017-08-10T13:06:20.442Z',
     '21.0.0-alpha.1': '2017-08-11T10:14:36.226Z' },
  readmeFilename: '',
  version: '0.0.0',
  dist: 
   { integrity: 'sha512-GX6M/nM+Qc+srkIDG26yR2LGURudFKE4r1d0vai+QCyDDlyTOPwCXAnPa5+mZkgfaMTrAEi4fI089geNOlY7CA==',
     shasum: 'eb9dee3fe1b34e9b2d6a138c44dc18bb62c3c3f0',
     tarball: 'https://registry.npmjs.org/jest-runner/-/jest-runner-0.0.0.tgz' },
  directories: {} }

@thymikee
Copy link
Collaborator

Hm, that may be the case. Can you check with "jest-runner": "test"?

@skovhus
Copy link
Contributor Author

skovhus commented Aug 20, 2017

"jest-runner": "test" didn't fix it. Still get Error: Cannot find module 'jest-runner' https://travis-ci.org/facebook/jest/builds/266556136?utm_source=github_status&utm_medium=notification

https://ci.appveyor.com/project/Daniel15/jest/build/4447 also seems to show some unrelated issues: { Error: 'SUGGEST_TO_EQUAL' is not exported by node_modules\jest-matcher-utils\build\index.js

@cpojer cpojer merged commit 388842b into jestjs:master Aug 20, 2017
@skovhus skovhus deleted the update-migration-guide branch August 20, 2017 18:51
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Update migration guide with jest-codemods transformers

* Try to fix Cannot find module 'jest-runner'

* Update package.json
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants