Do not modify stack trace of JestAssertionError #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniske
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4516 +/- ##
=======================================
Coverage 56.83% 56.83%
=======================================
Files 186 186
Lines 6306 6306
Branches 3 3
=======================================
Hits 3584 3584
Misses 2721 2721
Partials 1 1Continue to review full report at Codecov.
|
|
Added tests. |
|
Thanks for sending a PR! |
tabrindle
pushed a commit
to tabrindle/jest
that referenced
this pull request
Oct 2, 2017
* Do not modify stack trace of JestAssertionError. * Added test for stack trace of nested matchers. * Fixed test for nested matcher and added test for normal matchers. * Only comparing line numbers in test because function names in stack trace seem to be platform dependent.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4515
Test plan
No test plan yet.