Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watchAll not running tests on save #4550

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

truckingsim
Copy link
Contributor

@truckingsim truckingsim commented Sep 27, 2017

Summary

This fixes #4448. The change in #4254 caused createHasteMap to get false for watch. To not have to change watch logic elsewhere, I just added an or condition when we pass watch to the createHasteMap call.

Test plan

I'm open to options on testing this. It doesn't appear it was tested before and not really sure the best way for catch this in a test.

@cpojer
Copy link
Member

cpojer commented Sep 27, 2017

Thanks! Can you provide a video that confirms this is working with this change + what happened before?

@truckingsim
Copy link
Contributor Author

Before:

before

After:

after

@truckingsim
Copy link
Contributor Author

The flashing in this is due to my screen recorder, it doesn't flash like that normally...have never created these before.

@cpojer cpojer merged commit f710206 into jestjs:master Sep 27, 2017
@truckingsim truckingsim deleted the fix-watch-all branch September 27, 2017 22:12
@cpojer
Copy link
Member

cpojer commented Sep 27, 2017

Appreciated! Published Jest 21.2.1 for you, because I like you :)

@codecov-io
Copy link

Codecov Report

Merging #4550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4550   +/-   ##
=======================================
  Coverage   56.04%   56.04%           
=======================================
  Files         185      185           
  Lines        6268     6268           
  Branches        3        3           
=======================================
  Hits         3513     3513           
  Misses       2754     2754           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5992763...ec446e7. Read the comment docs.

tabrindle pushed a commit to tabrindle/jest that referenced this pull request Oct 2, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watchAll not running tests on save.
4 participants