Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rootDir tag in testEnvironment #4579

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Oct 2, 2017

Summary

rootDir was not replaced in custom testEnvironment, so it was harder to use custom unpublished environments. This PR fixes it.

Test plan

Added a test.

@codecov-io
Copy link

Codecov Report

Merging #4579 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4579      +/-   ##
==========================================
+ Coverage   55.63%   55.65%   +0.01%     
==========================================
  Files         186      186              
  Lines        6348     6348              
  Branches        3        3              
==========================================
+ Hits         3532     3533       +1     
+ Misses       2815     2814       -1     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/utils.js 75% <100%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b430e51...8591a9d. Read the comment docs.

@cpojer cpojer merged commit d355b3b into jestjs:master Oct 2, 2017
@cpojer
Copy link
Member

cpojer commented Oct 2, 2017

Oh yeah, that's a bug! Good seeing you @thymikee :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants