Check if npm_lifecycle_script calls jest directly #4629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4440. Check if
npm_lifecycle_script
callsjest
directly because it's possible that projects wrap the invocation of jest with some script. If jest is called directly, the snapshot update command is something likeyarn test -u
(note: the--
has been removed). Else suggest people "re-run jest with-u
".I
yarn link
'edjest-cli
tomy-app
which has thispackage.json
:where
run-tests.sh
is:#!/usr/bin/env bash jest
Running
yarn test-call-jest-directly
with failing snapshot tests yields:Running
yarn test-call-jest-indirectly
with failing snapshot tests yields: