Replace identity equality with Object.is in toBe matcher #4917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the strict equality (
===
) check withObject.is
in thetoBe
matcher.Object.is
works exactly the same as triple equals except:Hence, this allows us to fix #4907.
Test plan
Added two tests for
toBe
matcher. I couldn't test the docs due to #4911 and #4912, but changes are trivial.