Revert setRawMode on --watch quit (fixes #5028) #5029
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5029 +/- ##
==========================================
- Coverage 61.71% 61.68% -0.04%
==========================================
Files 213 213
Lines 7149 7153 +4
Branches 4 4
==========================================
Hits 4412 4412
- Misses 2736 2740 +4
Partials 1 1
Continue to review full report at Codecov.
|
|
@andyearnshaw This doesn't make any difference for me. |
|
@SimenB really? It fixed the problem for me. Can you post details about your environment please, so I can do some testing? |
|
@SimenB can you recheck this? The changes still work perfectly for me, switching off raw mode allows me to exit. Is it possible that you only pressed |
|
Yeah I'm gonna close this since it doesn't seem like anyone can reproduce it. |
|
I'll take a final look today |
|
I tested this again, and @andyearnshaw is correct - without these changes, it's impossible to @andyearnshaw mind rebasing on master? You'll need to update here as well: https://github.com/facebook/jest/blob/af191108302c719475aa34028a4ed46589b4cb9c/packages/jest-cli/src/plugins/quit.js#L12-L15 Also, please update the changelog |
|
Sure, I'll do it in the next few days.
…On Sun, 11 Feb 2018, 13:12 Simen Bekkhus, ***@***.***> wrote:
I tested this again, and @andyearnshaw <https://github.com/andyearnshaw>
is correct - without these changes, it's impossible to ^C out of a
watching Jest when debugging.
@andyearnshaw <https://github.com/andyearnshaw> mind rebasing on master?
You'll need to update here as well:
https://github.com/facebook/jest/blob/af191108302c719475aa34028a4ed46589b4cb9c/packages/jest-cli/src/plugins/quit.js#L12-L15
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5029 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvdEyJ6Jq07lKDVvCtAZgdy17jIj-C7ks5tTucugaJpZM4Q4Gp1>
.
|
andyearnshaw
force-pushed
the
patch-1
branch
from
b172147
to
54c83f2
Compare
|
Should be good to go now. Thanks for taking another look. |
|
Can you update the changelog as well, please? 🙂 |
* Revert setRawMode on --watch ctrl-c (jestjs#5028) * Disable stdin raw mode in watch quit plugin (jestjs#5028) * Update changelog
|
Thanks! 🙂 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The issue is detailed in #5028. The summary is that it's not possible to force Jest to quite while the inspector is still open when the
--watchparameter is provided.Test plan
There currently aren't any tests (that I could see) for handling the
qkey orCtrl-C/Ctrl-D, nor for the setup ofstdin.setRawMode(true), so I didn't add any for this either. However, it's a simple 2 lines of code and only runs on quit, so it's unlikely to cause any unwanted side-effects.