-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unofficial Node.js 4 support #5134
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5134 +/- ##
======================================
Coverage 60.7% 60.7%
======================================
Files 201 201
Lines 6691 6691
Branches 4 4
======================================
Hits 4062 4062
Misses 2628 2628
Partials 1 1
Continue to review full report at Codecov.
|
Thanks. I published jest@22.0.2. Good luck! |
Thanks. It was really fast :). |
@cpojer hm, strange. I fixed I checked |
I'm an idiot, I'll fix it in an hour. |
Alright done, it's 22.0.3 -.- |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Do I need to update
CHANGELOG.md
for unofficial fixes?Summary
I fixed Node.js 4 support to use Jest 22 in PostCSS, Autoprefixer, and Browserslist according to our plan in #5122
Test plan
I didn’t fix
...
in tests since Node.js 4 support is unofficial