Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing newline after "no files changed" #5308

Merged
merged 4 commits into from
Jan 14, 2018

Conversation

sachinmk27
Copy link
Contributor

@sachinmk27 sachinmk27 commented Jan 14, 2018

Address #5305
Summary
It was a case of operator precedence.
let msg = "\n" + isTrue ? "a": "b" // a
Added the ternary operator expression inside a pair of simple brackets.
let msg = "\n" + (isTrue ? "a": "b") // <newline>a

Test plan
Firstly, I tried out the changes in create-react-app. The screenshots are of the same.
Secondly, I ran jest -o after making my changes in the jest repo. All the relevant tests passed.

Before:
34916452-813e2602-f930-11e7-8d88-7494ac568dab

After:
screenshot from 2018-01-14 23-41-35

@gaearon
Copy link
Contributor

gaearon commented Jan 14, 2018

Heh, sorry I did that incorrect edit 😄

@codecov-io
Copy link

codecov-io commented Jan 14, 2018

Codecov Report

Merging #5308 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5308   +/-   ##
=======================================
  Coverage   61.23%   61.23%           
=======================================
  Files         205      205           
  Lines        6891     6891           
  Branches        3        3           
=======================================
  Hits         4220     4220           
  Misses       2670     2670           
  Partials        1        1
Impacted Files Coverage Δ
.../src/get_no_test_found_related_to_changed_files.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f5f79...b51bb06. Read the comment docs.

@gaearon
Copy link
Contributor

gaearon commented Jan 14, 2018

The build has previously passed, I think we can merge this! I just edited the changelog to use PR link instead of the issue number.

Nice work, thanks for finding this!

@sachinmk27
Copy link
Contributor Author

Thanks a lot @gaearon

@sachinmk27 sachinmk27 changed the title Fix missing newline after "no files changed" Fix missing newline after "no files changed" #5305 Jan 14, 2018
@sachinmk27 sachinmk27 changed the title Fix missing newline after "no files changed" #5305 Fix missing newline after "no files changed" Jan 14, 2018
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works great

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants