-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing newline after "no files changed" #5308
Conversation
Heh, sorry I did that incorrect edit 😄 |
Codecov Report
@@ Coverage Diff @@
## master #5308 +/- ##
=======================================
Coverage 61.23% 61.23%
=======================================
Files 205 205
Lines 6891 6891
Branches 3 3
=======================================
Hits 4220 4220
Misses 2670 2670
Partials 1 1
Continue to review full report at Codecov.
|
The build has previously passed, I think we can merge this! I just edited the changelog to use PR link instead of the issue number. Nice work, thanks for finding this! |
Thanks a lot @gaearon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works great
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Address #5305
Summary
It was a case of operator precedence.
let msg = "\n" + isTrue ? "a": "b" // a
Added the ternary operator expression inside a pair of simple brackets.
let msg = "\n" + (isTrue ? "a": "b") // <newline>a
Test plan
Firstly, I tried out the changes in create-react-app. The screenshots are of the same.
Secondly, I ran
jest -o
after making my changes in the jest repo. All the relevant tests passed.Before:
After: