Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-editor-support] update definition #6212

Merged
merged 1 commit into from
May 20, 2018
Merged

[jest-editor-support] update definition #6212

merged 1 commit into from
May 20, 2018

Conversation

stephtr
Copy link
Contributor

@stephtr stephtr commented May 20, 2018

According to the implementation the first parameter of Snapshot constructor is optional.
#trivial

@codecov-io
Copy link

Codecov Report

Merging #6212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6212   +/-   ##
=======================================
  Coverage   64.37%   64.37%           
=======================================
  Files         219      219           
  Lines        8453     8453           
  Branches        4        4           
=======================================
  Hits         5442     5442           
  Misses       3010     3010           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f5191...6568b58. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented May 20, 2018

@orta thoughts? I think it makes sense, but what do I know? 😀

@orta
Copy link
Member

orta commented May 20, 2018

Yeah, look like it handles undefined correctly 👍

https://github.com/facebook/jest/blob/f4f51914d577dc53748f599f3f626dfe3154883e/packages/jest-editor-support/src/Snapshot.js#L105-L106

@orta orta merged commit 9867e16 into jestjs:master May 20, 2018
@stephtr stephtr deleted the patch-1 branch May 20, 2018 21:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants