Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: transpile object shorthand syntax for node 4 compatibility #6582

Merged
merged 2 commits into from
Jul 3, 2018
Merged

chore: transpile object shorthand syntax for node 4 compatibility #6582

merged 2 commits into from
Jul 3, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jun 30, 2018 •
edited
Loading

Summary

This is needed to keep running on Node 4. Looking into it because of Prettier (prettier/prettier#4782).

Test plan

Validated that the syntax is gone

@SimenB SimenB mentioned this pull request Jun 30, 2018
Merged
@SimenB SimenB force-pushed the object-shorthand branch from 71c57d6 to f5d9a56 Compare June 30, 2018 10:48
@SimenB SimenB merged commit 6edbeb1 into jestjs:master Jul 3, 2018
@SimenB SimenB deleted the object-shorthand branch July 3, 2018 17:17
@endiliey
Copy link
Contributor

endiliey commented Jul 3, 2018

Website is down for around 10 mins 😢
down during https://circleci.com/gh/facebook/jest/27858
up after https://circleci.com/gh/facebook/jest/27859

cc @yangshun (joel is on PTO)

@yangshun
Copy link
Contributor

yangshun commented Jul 3, 2018 •
edited
Loading

I wonder if other Docusaurus users using CircleCI for deployment face the same problem.

@SimenB
Copy link
Member Author

SimenB commented Jul 3, 2018

Bah. I even made sure to cancel lots of builds to reduce the work 🙁

@endiliey
Copy link
Contributor

endiliey commented Jul 3, 2018 •
edited
Loading

If you look at https://github.com/facebook/Docusaurus/commits/gh-pages
Every push on master branch will only have 1 commit on gh-pages

But for jest, a push on master branch can cause > 1 commit on gh-pages
https://github.com/facebook/jest/commits/gh-pages
For example: when this PR got merged, there is two relevant commits on gh-pages. The first one bring it down and the second one doesn't & bring it up

I'm wondering if this is because we have double ci (travis ci & circle ci) in jest or there is something wrong with the yaml 😢

@SimenB
Copy link
Member Author

SimenB commented Jul 3, 2018

Oh, interesting find!

@endiliey
Copy link
Contributor

endiliey commented Jul 3, 2018

Actually I found out that the website is down when trying to refer to jestjs.io while writing test for Docusaurus 😂

Another finding is there is an unhandled promise.
image

I think caused by
https://github.com/facebook/jest/blob/6edbeb185720fbe0bb98220928c0e396f7902bd7/website/pages/en/index.js#L132-L136

Need to use safe getter on that

This was referenced Jul 4, 2018
Merged
Open
Merged
Open
Open
schalkneethling referenced this pull request in mdn/interactive-examples Jul 6, 2018
@renovate
chore(deps): update jest monorepo to v23.3.0 (#1012)
e1adf0d 
This Pull Request renovates the package group "jest monorepo".


-   [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0`
-   [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0`

# Release Notes
<details>
<summary>facebook/jest</summary>

### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#&#8203;2330)
[Compare Source](jestjs/jest@v23.2.0...v23.3.0)
##### Features

- `[jest-cli]` Allow watch plugin to be configured ([#&#8203;6603](`https://github.com/facebook/jest/pull/6603`))
- `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#&#8203;6380](`https://github.com/facebook/jest/pull/6380`))
##### Fixes

- `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#&#8203;6523](`https://github.com/facebook/jest/pull/6523`))
- `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#&#8203;6579](`https://github.com/facebook/jest/pull/6579`))
- `[jest-cli]` Fix enter to interrupt watch mode ([#&#8203;6601](`https://github.com/facebook/jest/pull/6601`))
##### Chore & Maintenance

- `[website]` Switch domain to https://jestjs.io ([#&#8203;6549](`https://github.com/facebook/jest/pull/6549`))
- `[tests]` Improve stability of `yarn test` on Windows ([#&#8203;6534](`https://github.com/facebook/jest/pull/6534`))
- `[*]` Transpile object shorthand into Node 4 compatible syntax ([#&#8203;6582](`https://github.com/facebook/jest/pull/6582`))
- `[*]` Update all legacy links to jestjs.io ([#&#8203;6622](`https://github.com/facebook/jest/pull/6622`))
- `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#&#8203;6623](`https://github.com/facebook/jest/pull/6623`))
- `[website]` Only test/deploy website if relevant files are changed ([#&#8203;6626](`https://github.com/facebook/jest/pull/6626`))
- `[docs]` Describe behavior of `resetModules` option when set to `false` ([#&#8203;6641](`https://github.com/facebook/jest/pull/6641`))

---


</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Jul 7, 2018
Closed
Merged
Closed
This was referenced Aug 1, 2018
Open
Open
@dependencies dependencies bot mentioned this pull request Nov 1, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimenB @endiliey @yangshun @thymikee @facebook-github-bot