fix toContain suggest to contain equal message
#6810
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #6810 +/- ##
==========================================
+ Coverage 63.56% 63.63% +0.07%
==========================================
Files 235 235
Lines 9026 9017 -9
Branches 3 4 +1
==========================================
+ Hits 5737 5738 +1
+ Misses 3288 3278 -10
Partials 1 1
Continue to review full report at Codecov.
|
|
Mind adding a changelog? :) |
Gregjarvez
force-pushed
the
fix-toContain-matchers-output
branch
from
870ebcb
to
16aacad
Compare
|
Fix lint and we can merge this :) |
|
in a bit !!. |
Gregjarvez
force-pushed
the
fix-toContain-matchers-output
branch
from
16aacad
to
2afbf5b
Compare
* upstream/master: (122 commits) fix: don't report promises as open handles (jestjs#6716) support serializing `DocumentFragment` (jestjs#6705) Allow test titles to include array index (jestjs#6414) fix `toContain` suggest to contain equal message (jestjs#6810) fix: testMatch not working with negations (jestjs#6648) Add test cases for jestjs#6744 (jestjs#6772) print stack trace on calls to process.exit (jestjs#6714) Updates SnapshotTesting.md to provide more info. on snapshot scope (jestjs#6735) Mark snapshots as obsolete when moved to an inline snapshot (jestjs#6773) [Docs] Clarified the use of literal values as property matchers in toMatchSnapshot() (jestjs#6807) Update CHANGELOG.md (jestjs#6799) fix changelog entry that is not in 23.4.2 (jestjs#6796) Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options (jestjs#6736) Update testURL default value from about:blank to localhost (jestjs#6792) fix: `matchInlineSnapshot` when prettier dependencies are mocked (jestjs#6776) Fix retryTimes and add e2e regression test (jestjs#6762) Release v23.4.2 Docs/ExpectAPI: Correct docs for `objectContaining` (jestjs#6754) chore(packages/babel-jest) readme (jestjs#6746) docs: noted --coverage aliased by --collectCoverage (jestjs#6741) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #6808
Summary
toContainprovides a useful "suggest to contain equal" message. This is however not formatted properly.This PR add a line break to enhance readability.
Test plan
Only updated snapshots.