Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents watchers from being awake by created folders #6818

Merged
merged 3 commits into from
Aug 10, 2018
Merged

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Aug 9, 2018

Summary

Jest Haste Map has an issue that cause it to crash when a folder named [something].js is created. The only check it does it by extension, which isn't good enough (running yarn add md5.js would cause a crash, for example).

Test plan

Not sure how to test folder creation with the Jest Haste Map test infra?

@mattphillips
Copy link
Contributor

mattphillips commented Aug 9, 2018

Hey @arcanis I think we could add an e2e test for this similar to these tests by creating a directory with name.js/ instead of a file.

Also it looks like you will need to update the haste map unit tests that mock out fs.stats see here to include the isDirectory function

@SimenB
Copy link
Member

SimenB commented Aug 9, 2018

(also missing a changelog in addition to the test :D)

@arcanis
Copy link
Contributor Author

arcanis commented Aug 9, 2018

Added a test, fixed the linting, updated the changelog 🙂

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants