-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show stack traces on async assert errors #6821
Conversation
If the plan is to ditch jest-jasmine, I say leave it and just close this PR. If the plan is to keep jest-jasmine around for some time, we should fix this 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, so why not fixing that :)
41b47b6
to
a12f081
Compare
Took a look, it differed because of a double-wrapping in |
Codecov Report
@@ Coverage Diff @@
## master #6821 +/- ##
==========================================
- Coverage 66.89% 63.41% -3.48%
==========================================
Files 251 235 -16
Lines 10488 9116 -1372
Branches 4 4
==========================================
- Hits 7016 5781 -1235
+ Misses 3471 3334 -137
Partials 1 1
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
While jest-circus worked just like it should (🎉), jest-jasmine only checked for node assert on thrown errors, not rejected ones (from async errors).
Not sure about the best way to fix the test assertion for Circus. Failure looks like this:
Fixes #6752
Test plan
Test added