[jest-each]: Add flag to prevent done callback being supplied to describe #6843
Conversation
mattphillips
force-pushed
the
jest-each-describe-done
branch
from
2c1fede to
0a81b2f
Compare
packages/jest-each/src/bind.js
Outdated
| test: Function, | ||
| ) => { | ||
| if (supportsDone && params.length < test.length) | ||
| return done => test(...params, done); | ||
|
|
||
| return () => test(...params); |
There was a problem hiding this comment.
nit: can we fold it to:
return supportsDone && params.length < test.length
? done => test(...params, done)
: () => test(...params)same suggestion for applyObjectParams below
There was a problem hiding this comment.
Like it! may as well drop the return too 😜 what do you think of this?
const applyRestParams = (
supportsDone: boolean,
params: Array<any>,
test: Function,
) => supportsDone && params.length < test.length
? done => test(...params, done)
: () => test(...params);There was a problem hiding this comment.
Yea, I usually have a lint rule to fix it for me :p
Codecov Report
@@ Coverage Diff @@
## master #6843 +/- ##
==========================================
- Coverage 63.43% 63.42% -0.01%
==========================================
Files 235 235
Lines 9115 9114 -1
Branches 4 4
==========================================
- Hits 5782 5781 -1
Misses 3332 3332
Partials 1 1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Currently
jest-eachassumes if a test callback has more arguments than supplied in the data (array/template) then the extra argument is adonecallback. This logic should not apply fordescribeblocks as they do not supportdonecallbacks (or any args for that matter).Fixes: #6838
Test plan
Updated unit tests to check
describeblocks aren't invoked withdone