Preserve info from files with matching SHA-1s #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjesun
changed the title
mjesun
approved these changes
Sep 17, 2018
rubennorte
force-pushed
the
preserve-file-data-for-matching-sha1
branch
from
38c79fa
to
5c8456a
Compare
|
Changelog? 😁 |
|
@SimenB I never add them in the first commit because I need the PR number, and then I always forget 😅 |
SimenB
approved these changes
Sep 17, 2018
|
The lint failure CI complains about has been fixed on master, so this PR is actually green |
rubennorte
force-pushed
the
preserve-file-data-for-matching-sha1
branch
from
5c8456a
to
89f97d1
Compare
|
@rubennorte Why is this breaking? |
|
@mjesun it's not. The breaking part is just a typo in the previous message. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation of the watchman crawler ignores any previous information for files with different modification time. This modifies that part to also preserve the information for files with the same sha-1.
Test plan
Updated the test suite.