Fix unhandled error when a bad revision is provided to changedSince
#7115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is cleaner than the original approach, but I pushed an alternate version moving the logic to |
SimenB
approved these changes
Oct 7, 2018
|
@SimenB looks great and even cleaner than what I did. 👍 |
khuyn003
commented
Oct 7, 2018
| }).catch(e => { | ||
| const message = formatExecError(e, configs[0], {noStackTrace: true}) | ||
| .split('\n') | ||
| .filter(line => !line || !line.includes('Command failed:')) |
There was a problem hiding this comment.
That's on purpose - we want to keep the newlines in the output. This is how it looks:
The condition is there in case typeof line !== 'string', but thinking about it, that can't happen
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #7025 – when a bad revision is passed to the
--changedSinceargument, causing an unhandled rejection error message. It will now output the error message from git/hg instead.Before:
After:
Test plan
Updated integration tests.