-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update setupFiles documentation for improved clarity #7187
update setupFiles documentation for improved clarity #7187
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Would you be so kind update versioned docs too? And add a changleog :) |
docs/Configuration.md
Outdated
|
||
It's worth noting that this code will execute _before_ [`setupTestFrameworkScriptFile`](#setuptestframeworkscriptfile-string). | ||
It's also worth noting that setupFiles will execute _before_ [`setupTestFrameworkScriptFile`](#setuptestframeworkscriptfile-string). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrap in backtciks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops sure.
ack i thought I added the changelog... sorry! |
…clarity around expected setupfile behavior
709fc71
to
e8b42fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #7187 +/- ##
==========================================
+ Coverage 67.22% 67.31% +0.08%
==========================================
Files 248 248
Lines 9627 9615 -12
Branches 4 4
==========================================
Hits 6472 6472
+ Misses 3154 3142 -12
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @bambielli for your first Jest contribution 🎉 |
Thank you! I <3 Jest, and am converting many of my coworkers over to it from Mocha/Chai/Sinon. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See #7174 for issue.
setupFiles
documentation was misleading. This PR makes it clearer that setupFiles are only expected to run once per test file, not once per test.Test plan
N/A (documentation change)