Allow multilple valid types

[jamietre]

Summary

Split from #7194
Prerequisite to resolving #7180

This PR provides a syntax for jest-validate to accept more than one example for a single config value, which can be of different types. This allows overloading config options to accept multiple types.

Test plan

• existing unit tests pass (except as expected where internal config changed types)
• added unit tests to cover new valid and error conditions

[SimenB]

could you include a link to this PR?

[jamietre]

Done.

[thymikee]

That's cool! I left some nits to fix.
I'm still thinking about syntax. What do you think is better:

key: [MultipleValidOptions, a, b]

or

key: MultipleValidOptions(a, b)

I'd prefer the second one, but no hard opinions on that.

[thymikee]

how about

const validTypes = Array.from(new Set(conditions.map(getType))).join(' or ');

[jamietre]

On syntax, I think I was channeling a JSON-compatible config, but I guess that doesn't really matter if we need to use a Symbol to make it deterministic.

If we use a function, it's still going to have to return something that can be identified by the parser, so we'd still probably do something like [_MultipleValidOptions, ...] anyway internally. That seems okay, though seems to add a small amount of complexity to improve the usage a little bit.

Actually, I agree this is better, just because it eliminates ambiguity at the use site between this and a real array.

[thymikee]

I think it should be as simple as:

function MultipleValidOptions(...args) {
  return args
}

MultipleValidOptions.$$type = Symbol('jest-validate-multiple-valid-options');

You get an array of values just like in current implementation

[jamietre]

I think it should be as simple as:

function MultipleValidOptions(...args) {
  return args
}

MultipleValidOptions.$$type = Symbol('jest-validate-multiple-valid-options');

You get an array of values just like in current implementation

Not sure I understand... if someone codes

const validOptions = {
   key: MultipleValidOptions(1, '2')
};

using this definition, then validOptions.key is [1, '2'] which is simply an array, unless there's some magic meaning to $$type I don't know about?

[jamietre]

Changed per the API you proposed; if there's a more trivial implementation I'm missing here then happy to revise.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.