Remove redundant information from the config hash part of the haste map #7218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
force-pushed
the
remove-haste-name-prefix-from-config-hash
branch
2 times, most recently
from
c9d922a
to
7d5c48a
Compare
rubennorte
force-pushed
the
remove-haste-name-prefix-from-config-hash
branch
from
7d5c48a
to
e712705
Compare
rubennorte
force-pushed
the
remove-haste-name-prefix-from-config-hash
branch
from
e712705
to
66ef0b3
Compare
mjesun
approved these changes
Oct 19, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This simplifies the remote caching of haste map files. Right now the haste map name is structured as
haste-map-${name}-${rootDirHash}-${configHash}. This modifies theconfigHashso it's not affected by therootDirHash(and passes the project name so it's still taken into account).Test plan
Updated unit tests.