-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serialization issues with RegExp instances in the normalized config #7251
Fix serialization issues with RegExp instances in the normalized config #7251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Should revert (but keep the test) later :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! That was fast! Thanks a lot! ❤️
@SimenB I'm not sure I got that. Do you mean that we should revert this when we decide what to do with the serialization issue? |
Yes :) I think we should normalize all config in |
It's tricky when the workers are involved, but I agree. |
0240d6e
to
8c633db
Compare
Codecov Report
@@ Coverage Diff @@
## master #7251 +/- ##
=========================================
- Coverage 66.55% 66.5% -0.05%
=========================================
Files 237 241 +4
Lines 9317 9328 +11
Branches 4 6 +2
=========================================
+ Hits 6201 6204 +3
- Misses 3115 3121 +6
- Partials 1 3 +2
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #7242 introduced in #7209, where the configuration was incorrectly serialized as it contained
RegExp
instances (incompatible with the automatic JSON serialization done natively by Node.js inchild_process.send
.Test plan
Updated unit and e2e tests.