Fix recovery of haste collisions #7329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafeca
force-pushed
the
fix-recovery-of-haste-collisions
branch
5 times, most recently
from
8712cd5
to
16b094d
Compare
jeanlauliac
previously requested changes
Nov 6, 2018
The cache system of Regarding performance, I wouldn't worry here since the number of duplicates in the haste map should be rather small |
rafeca
dismissed
jeanlauliac’s stale review
Answered the concern that @jeanlauliac had
jeanlauliac
approved these changes
Nov 7, 2018
rafeca
force-pushed
the
fix-recovery-of-haste-collisions
branch
from
16b094d
to
e2f21d4
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jest-haste-maphad a bug when recovering from a haste name collision: it was using thetypefrom the deleted file instead of the type from the remaining file in the haste map.This PR fixes this issue, while it also changes the internal data structure that holds the duplicated modules.
I've split the PR into two commits: the first one only fixes the issue and the second one converts the
duplicatesstructure into aMap. We can discard the second commit if needed.I've marked the change as a breaking change since the duplicated modules are part of the public API of
jest-haste-map(although it should be very rare for a user to rely on this).Test plan
I've created a new unit test that ensures the correct behaviour (that test would fail currently in master).