Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-plugin-jest-hoist: Ignore TS type annotations when looking for out-of-scope references #7641

Merged
merged 5 commits into from
Jan 16, 2019

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Jan 16, 2019

Summary

Closes #7634, fixes #7633

Now that I've looked at the rest of babel-plugin-jest-hoist too, it's actually a lot easier.
My ugly stateful visitor ideas were nice and everything, but turns out we've already had this solved properly for Flow 🙈

Test plan

e2e test added by @SimenB, checked that it fails with babel-plugin-jest-hoist from master.

@SimenB
Copy link
Member

SimenB commented Jan 16, 2019

Oh, wow, haha! So simple in the end 😀 Thank you so much!

@SimenB SimenB merged commit df8dfef into jestjs:master Jan 16, 2019
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock factories do not support explicit TypeScript typing using imported types
3 participants