-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add option to disable worker_threads
in jest-worker
#7681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me assuming the tests pass ;)
Let's get rid of this option once worker threads are known to be stable. |
I think it's fair to remove it once Node promotes it from experimental status (it's still experimental even though it's unflagged). However, as discussed, I'll swap this so it's opt-in rather than opt-out |
…7681) * fix: add option to disable `worker_threads` in `jest-worker` * link to PR
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
There are certain issues around
worker_threads
(notably missingprocess.umask
, which makes a few dependencies throw). While these issues are getting fixed (npm/write-file-atomic#37 & nodejs/node#25526) I think we should be on the safe side with Jest 24 and wait for the dust to settle before using it in Jest.However, the default behavior is still to use it if available, this PR explicitly disables it in the places we use
jest-worker
internally.EDIT: Follow-up making it opt-in: #7693
Test plan
Unit test added. This should also fix CI for node 11.