Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure normalize accepts defaults #7742

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 29, 2019

Summary

Fixes #7741

Test plan

Test added

@@ -200,7 +200,9 @@ const normalizeCollectCoverageFrom = (options: InitialOptions, key: string) => {
value = JSON.parse(options[key]);
} catch (e) {}

Array.isArray(value) || (value = [options[key]]);
if (value && !Array.isArray(value)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it ended up being [null], which threw below in the loop.

Also, super weird to use || then assignment...


describe('Defaults', () => {
it('should be accepted by normalize', () => {
normalize({...Defaults, rootDir: '/root'}, {});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rootDir is added by readConfig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to preserve that information 😄

Suggested change
normalize({...Defaults, rootDir: '/root'}, {});
// rootDir is added by readConfig
normalize({...Defaults, rootDir: '/root'}, {});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason, it's used like this all over this test file

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit to address, other than that looks good, thanks for a little cleanup!

packages/jest-config/src/ValidConfig.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


describe('Defaults', () => {
it('should be accepted by normalize', () => {
normalize({...Defaults, rootDir: '/root'}, {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to preserve that information 😄

Suggested change
normalize({...Defaults, rootDir: '/root'}, {});
// rootDir is added by readConfig
normalize({...Defaults, rootDir: '/root'}, {});

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-validate complains about cwd in Jest 24 with jest-config for defaults
4 participants