fix: handle missing todo in test result #7779
Conversation
SimenB
force-pushed
the
handle-missing-todo-in-result
branch
from
87cdc70
to
b5ad2ce
Compare
| // `todos` are new as of Jest 24, and not all runners return it. | ||
| // Set it to `0` to avoid `NaN` | ||
| if (!testResult.numTodoTests) { | ||
| testResult.numTodoTests = 0; |
There was a problem hiding this comment.
isn't this something that runners should add themselves for Jest 24 compat, like we did in create-jest-runner?
There was a problem hiding this comment.
sure, but IMO we shouldn't require runners to do so. The fact they have to return a huge results object at all is pretty sad. The real fix IMO would be for runners to return something minimal, and we do a const result = {...defaultResultObject, ...returnValueFromRunner} (something more clever for deep merge, but essentially this). Should be enough to return e.g. {pass: true, start: timestamp, end: timestamp} or something like that
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes jest-community/jest-runner-eslint#64
Test plan
It works 😅 Any tests I write is gonna feel pretty convoluted...