Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image URLs #7872

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Fix image URLs #7872

merged 3 commits into from
Feb 12, 2019

Conversation

georgeblahblah
Copy link
Contributor

Summary

When browsing the docs website, images under the topic Snapshot Testing were returning a 404. The paths to these images were incorrect. Instead of loading from /website/static/img they should be loaded from /img

Test plan

N/A

Images were loaded from `/website/static/img/..`, which returns a 404. The
correct path is `/img/..`
@jeysal
Copy link
Contributor

jeysal commented Feb 12, 2019

Works on the netlify preview, thanks!
You can move the changelog entry to the Chore section, fixes and features usually only contain changes to Jest itself.
I'll update the contributing guide with some info on adding changelog entries.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
@georgeblahblah georgeblahblah deleted the docs-fix-image-urls branch October 29, 2021 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants