-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Prototype Pollution vulnerability in Handlebars dependency #7904
Fixes Prototype Pollution vulnerability in Handlebars dependency #7904
Conversation
…e Pollution found in handlebars dependency
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks @tonycassara! Note that since the new version is in semver range, you don't need to wait for Jest to publish a new version to avoid the vulnerable dependency - just upgrade locally and make sure it's in your lockfile |
Cool thanks @SimenB ! Will make those changes locally. |
|
That worked perfectly thank you |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
jest-cli
is affected by a vulnerability published today on NPM: https://www.npmjs.com/advisories/755This updates the offending package
istanbul-api
and subsequentlyistanbul-reports
to the version needed to no longer have thehandlebars
vulnerability.Test plan
I used
yarn upgrade istantbul-api@2.1.1
in the directoryjest/packages/jest-cli