Fix missing error after test #8005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Feb 28, 2019
packages/jest-circus/src/utils.ts
Outdated
| @@ -230,6 +246,9 @@ export const callAsyncCircusFn = ( | |||
| timeoutID.unref && timeoutID.unref(); | |||
| clearTimeout(timeoutID); | |||
| throw error; | |||
| }) | |||
| .finally(() => { | |||
| completed = true; | |||
There was a problem hiding this comment.
not too happy about this, but we don't have access to the test definition, and the promise has already been resolved. Might make sense to dispatch some "suite failed" event or something like that?
@aaronabramov thoughts?
SimenB
force-pushed
the
error-after-test
branch
from
661bf46 to
47fc113
Compare
|
bah, node 6 and 8 doesn't have |
SimenB
force-pushed
the
error-after-test
branch
from
b52b8c6 to
3401546
Compare
elenap1991
added a commit
to elenap1991/external-courses
that referenced
this pull request
May 26, 2019
due to jest fix jestjs/jest#8005 After this update travis would output real errors of css validation tests
This was referenced Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is #6794 with a test.
The error isn't pretty, but I think it's fine. Since we're tearing down (and use lazy requires), we might get an error when trying to prettify it
Test plan
Green CI