-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing TextEncoder and TextDecoder to jest-envirotment-node #8022
Conversation
Should we use these node globals to polyfill on jest-environment-jsdom? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node 11 ref nodejs/node@932be01
Same thing for URL{,SearchParams} #6231
Assuming we don't need a test for this since #6231 didn't have one either?
I don't think so, that's |
Codecov Report
@@ Coverage Diff @@
## master #8022 +/- ##
=========================================
Coverage ? 64.08%
=========================================
Files ? 262
Lines ? 10175
Branches ? 1820
=========================================
Hits ? 6521
Misses ? 3253
Partials ? 401
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Added missing globals to jest-environment-node. Use the same approach as the URL.
These were added in node 11: https://nodejs.org/api/globals.html#globals_textdecoder
Test plan
I tested locally with yarn link. I am not sure if pipeline have node11?