Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing TextEncoder and TextDecoder to jest-envirotment-node #8022

Merged
merged 3 commits into from
Mar 2, 2019

Conversation

chyzwar
Copy link
Contributor

@chyzwar chyzwar commented Mar 2, 2019

Summary

Added missing globals to jest-environment-node. Use the same approach as the URL.

These were added in node 11: https://nodejs.org/api/globals.html#globals_textdecoder

Test plan

I tested locally with yarn link. I am not sure if pipeline have node11?

@chyzwar
Copy link
Contributor Author

chyzwar commented Mar 2, 2019

Should we use these node globals to polyfill on jest-environment-jsdom?

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 11 ref nodejs/node@932be01
Same thing for URL{,SearchParams} #6231

Assuming we don't need a test for this since #6231 didn't have one either?

@SimenB
Copy link
Member

SimenB commented Mar 2, 2019

Should we use these node globals to polyfill on jest-environment-jsdom?

I don't think so, that's jsdom's responsibility

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c3a0167). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8022   +/-   ##
=========================================
  Coverage          ?   64.08%           
=========================================
  Files             ?      262           
  Lines             ?    10175           
  Branches          ?     1820           
=========================================
  Hits              ?     6521           
  Misses            ?     3253           
  Partials          ?      401
Impacted Files Coverage Δ
packages/jest-environment-node/src/index.ts 48.48% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a0167...54b3ea1. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants