Change method of obtaining git root (#3214) #8052
Conversation
On various environments like cygwin path returned by --show-toplevel is cygwin path, not windows path. Instead of that --show-cdup can be used and merged with root of npm project giving root of git repo
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
...but sadly i figured out, that my fix is double-edged sword. Now root of the git project is correct, but args are still wrong. on line 67
I'm going to work on it during this week |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
For execa it does not matter if path is ended with folder separator
Instead of absolute path, use path relative to git root. Thanks to that it works on various windows enviroments etc. Cygwin which requires cygwin path if absolute
for case path.relative(dir, dir) returning ''
|
done |
Co-Authored-By: bwiercinski <bmwbartek1@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #3214
On various environments like cygwin path returned by
--show-toplevelis cygwin path, not windows path. Instead of that--show-cdupcan be used and merged with root of npm project giving root of git repoTest plan
I hope CICD test verify that this solution is still working on linux :)