Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialize changedFiles passed to workers #8090

Merged
merged 5 commits into from
Mar 8, 2019

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Mar 8, 2019

Summary

Serialize Set to Array in coverage and test workers.
Fixes #8084.

Test plan

@SimenB feel free to add a test, I need to run away from my computer at the moment.

@thymikee thymikee force-pushed the fix/serialize-changed-files branch from 183cd48 to 43e2e3c Compare March 8, 2019 17:48
@@ -86,7 +86,10 @@ export async function worker({
globalConfig,
config,
getResolver(config, moduleMap),
context,
context && {
...config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context not config, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, how did that passed typecheck :o

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think config is a superset of context

@thymikee thymikee merged commit 17ffcc9 into jestjs:master Mar 8, 2019
@thymikee thymikee deleted the fix/serialize-changed-files branch March 8, 2019 19:42
@leonfs
Copy link

leonfs commented Mar 11, 2019

Is there a date on when is this going to be released? Not being able to watch tests if coverage is enabled is quite a pain.

@SimenB
Copy link
Member

SimenB commented Mar 11, 2019

Hopefully today

@arb
Copy link

arb commented Mar 11, 2019

I updated to 24.4.0 and am still having the issue described in #8084 and #8088.

npx: installed 1 in 1.147s

  System:
    OS: macOS 10.14.3
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 8.11.1 - ~/.nvm/versions/node/v8.11.1/bin/node
    Yarn: 1.9.4 - ~/.nvm/versions/node/v8.11.1/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.11.1/bin/npm
  npmPackages:
    jest: 24.x.x => 24.4.0 

@SimenB
Copy link
Member

SimenB commented Mar 11, 2019

Could you put together a reproduction?

@arb
Copy link

arb commented Mar 11, 2019

Same repo as #8088

https://github.com/arb/celebrate/tree/feature-ref

That branch, npm test locally fails with the same error. I've bumped to jest@24.4.0 and it's failing in the same way. I apologize it's not a small repo. I tried starting a new project with the same setup, but I couldn't get it to fail the same way.

@thymikee
Copy link
Collaborator Author

@arb it's a problem you your package manager. Try yarn or at least remove Jest references from package-lock.json.

Running:

yarn
yarn jest --changedSince=master
yarn jest --watch

works just fine.

@arb
Copy link

arb commented Mar 11, 2019

@thymikee removed all of package-lock.json and re-ran npm i; same problem. Removed package-lock.json and ran yarn jest --watch; same problem. Worth noting is that --changedSince=master did seem to work.

The (currently) two 👍on #8090 (comment) makes me think there are others who have tried the new version and are having the same problem even after the update. Are there any suggestions for how I can help resolve this issue?

@leonfs
Copy link

leonfs commented Mar 13, 2019

We have upgraded and it's working fine for us. Many thanks @SimenB !!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with version 24.3.0 using --changedSince flag
5 participants