[expect] Fix circular references in iterable equality

[mattphillips]

Summary

Fixes #6830, closes #7526

This uses the same algorithm as eq in jasmineUtils

Test plan

See unit tests

[SimenB]

Missing changelog, code LGTM

[jeysal]

@mattphillips we should also try how this works at different depths, e.g.

const a1 = new Set();
const a2 = new Set();
a1.add(a2);
a2.add(a1);
const b = new Set();
b.add(b);

expect(iterableEquality(a1, b)).toBe(true);

That would make it very similar to #7730

[pedrottimark]

Yes, please see the recent pull request or the algorithm in pretty-format if it is more appropriate.

[SimenB]

These pops (and the algorithm in general) deserves some clarifying comments

[SimenB]

iterableEqualityWithStack?

[codecov-io]

Codecov Report

Merging #8160 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8160      +/-   ##
==========================================
+ Coverage   62.28%   62.35%   +0.06%     
==========================================
  Files         265      265              
  Lines       10440    10455      +15     
  Branches     2538     2541       +3     
==========================================
+ Hits         6503     6519      +16     
  Misses       3352     3352              
+ Partials      585      584       -1

Impacted Files	Coverage Δ
packages/expect/src/utils.ts	96.55% <100%> (+1.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5fd7aa...2e4611f. Read the comment docs.

[mattphillips]

@jeysal see ef47fa2 for:

const a1 = new Set();
const a2 = new Set();
a1.add(a2);
a2.add(a1);
const b = new Set();
b.add(b);

expect(iterableEquality(a1, b)).toBe(true);

[jeysal]

@mattphillips You probably have a good high-level overview of how the algorithm works in your head right now, any chance you could write a few lines about that as a comment for iterableEquality?

[thymikee]

@mattphillips @jeysal yea, I think we'd all love that. Please do so in a followup :)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.