-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache JestHook emitters #8746
Cache JestHook emitters #8746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea makes sense. Want to take it a step further and switch the data structure of this._listeners
to a Map
for more perf wins?
This may impair readability and convenience. hooks.getEmitter().onTestRunComplete(results); vs hooks.getEmitter().get('onTestRunComplete')(results); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's make sure this gets in for the release-- just needs a changelog. |
2a4d7dc
to
f96a3b9
Compare
done @scotthovestadt |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Just cached
JestHookSubscriber
andJestHookEmitter
to avoid creating new object on eachgetSubscriber()
,getEmitter()
calls.Test plan