Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache JestHook emitters #8746

Merged
merged 2 commits into from
Aug 3, 2019
Merged

Conversation

Connormiha
Copy link
Contributor

Summary

Just cached JestHookSubscriber and JestHookEmitter to avoid creating new object on each getSubscriber(), getEmitter() calls.

Test plan

Copy link
Contributor

@scotthovestadt scotthovestadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea makes sense. Want to take it a step further and switch the data structure of this._listeners to a Map for more perf wins?

@Connormiha
Copy link
Contributor Author

The idea makes sense. Want to take it a step further and switch the data structure of this._listeners to a Map for more perf wins?

This may impair readability and convenience.

hooks.getEmitter().onTestRunComplete(results);

vs

hooks.getEmitter().get('onTestRunComplete')(results);

Copy link
Contributor

@rogeliog rogeliog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scotthovestadt
Copy link
Contributor

Let's make sure this gets in for the release-- just needs a changelog.

@Connormiha Connormiha force-pushed the cache-jest-hooks-emitters branch from 2a4d7dc to f96a3b9 Compare August 3, 2019 08:51
@Connormiha
Copy link
Contributor Author

Let's make sure this gets in for the release-- just needs a changelog.

done @scotthovestadt

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants