Support transforming testRunner with preset/transform #8823

Mark1626 · 2019-08-14T17:00:43Z

Summary

Support transforming testRunner with transform
Part of #8810

Test plan

Have added a test for transforming testRunner

Mark1626 · 2019-08-14T17:06:28Z

e2e/babel-plugin-jest-hoist/package.json

+    "testEnvironment": "node",
+    "transformIgnorePatterns": [
+      "jest-jasmine2",
+      "jest-circus"


Adding jest-circus as well so that when it becomes the default runner the tests won't fail

Mark1626 · 2019-08-14T17:09:29Z

e2e/coverage-transform-instrumented/package.json

+      "jest-jasmine2",
+      "jest-each",
+      "jest-circus"
+    ],


These will have to be ignored manually as a relative path to the package is used rather than node_modules.
Seems like the number of ignore paths might increase going forward, one idea I had was to add a pattern like jest-, but that doesn't seem to work in all cases

e2e/transform/transform-testrunner/test-runner.ts

e2e/transform/babel-jest-ignored/babel.config.js

SimenB · 2019-08-15T08:15:10Z

e2e/transform/transform-testrunner/test-runner.ts

+  runtime: Runtime,
+  testPath: string
+): Promise<TestResult> {
+  return Promise.resolve({


just make the function async rather than Promise.resolve?

we really should have a helper for creating "empty" test results. This is a pain for custom runners (as you can see here)

packages/jest-runner/package.json

SimenB

I'm not sure if we should document that it can be transformed? Since everything should be transformable at some point it might not be worth it I guess

Mark1626 · 2019-08-15T13:38:51Z

You mean a single CHANGELOG entry specifying that all everything is transformable?

packages/jest-runner/tsconfig.json

SimenB · 2019-08-15T14:21:11Z

No, I meant in the documentation. I tmight be what people expect though, so no need. dunno!

G-Rath · 2019-08-18T20:20:14Z

I'm not sure if we should document that it can be transformed? Since everything should be transformable at some point it might not be worth it I guess

Personally I agree w/ this - which is the whole reason why I started this "Transform EVERYTHING!!" spree: it's really unexpected for somethings but not others to be transformed.

You mean a single CHANGELOG entry specifying that all everything is transformable?

I think that's the best way to go about this CHANGELOG wise - otherwise we're all going to be making near-identical CHANGELOG entries.

We could update the same log entry on our PRs, but that'd mean each PR would need to be rebased as the others are merged.

I think what if we opened a new PR right now for just the CHANGELOG entry? that way we could have it prepared & it won't be forgotten, since it'll be there on the list of open PRs.

Mark1626 · 2019-08-19T18:12:34Z

@SimenB @G-Rath I've created a util in jest-util for creating an empty test result as suggested.
This will affect the TestResult generated by jest-jasmine2, previously it was missing some of the required fields.

Will be move it to a separate PR, wanted you opinion before that

Mark1626 · 2019-08-19T18:14:24Z

packages/jest-util/src/emptyTestResult.ts

+
+import {TestResult} from '@jest/test-result';
+
+export default function emptyTestResult(): TestResult {


This seems to the minimal TestResult template that I could create

Is there a legacy reason why leaks is mandatory, it looks like an optional field

leaks should be optional, probably just an oversight. It's just a boolean though, right?

SimenB · 2019-08-20T09:17:40Z

I've created a util in jest-util for creating an empty test result as suggested.

Could you add it to @jest/test-result instead? https://github.com/facebook/jest/blob/d523fa84f2a65adf4d18019173dd44600c57bcad/packages/jest-test-result/

Mark1626 · 2019-08-22T13:39:35Z

Could you add it to @jest/test-result instead? https://github.com/facebook/jest/blob/d523fa84f2a65adf4d18019173dd44600c57bcad/packages/jest-test-result/

Moving this to a separate PR and reverting it util over here.

Mark1626 · 2019-08-25T11:45:26Z

There seems to be a memory leak in the test for node 10.
Not sure if this is coming from this PR

SimenB · 2019-08-25T11:46:49Z

You can rebase for a fix for the leak

Mark1626 · 2020-11-15T05:11:51Z

CI is failing due to the yarn lock. The lock file will be modified in this PR as jest-runner will need @jest/transform, I have committed the change in lock as well, can you approve the modification in lock @SimenB

SimenB · 2020-11-15T11:27:46Z

@Mark1626 yeah, that lockfile change looks correct 👍

Mark1626 · 2020-11-15T11:59:05Z

Fixing this test now, I'll update once done

/home/runner/work/jest/jest/e2e/__tests__/v8Coverage.test.ts

  ● prints coverage with empty sourcemaps

    expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 1

      34 |   );
      35 | 
    > 36 |   expect(exitCode).toBe(0);
         |                    ^
      37 |   expect(wrap(stdout)).toMatchSnapshot();
      38 | });
      39 | 

      at Object.toBe (e2e/__tests__/v8Coverage.test.ts:36:20)

Mark1626 · 2020-11-15T12:17:05Z

e2e/v8-coverage/empty-sourcemap/babel.config.js

@@ -6,5 +6,13 @@
 */

 module.exports = {
-  presets: ['@babel/preset-env', '@babel/preset-typescript'],
+  presets: [
+    ['@babel/preset-typescript'],


@SimenB I'm totally not sure why thing makes the test pass, any pointers?

doesn't make much sense - this shouldn't be needed at all

it's the same as the others - we either need to not transpile our runner or make sure to transpile it correctly (via adding targets since we don't want weird async function transpilation)

SimenB · 2020-11-15T12:48:21Z

e2e/v8-coverage/empty-sourcemap/babel.config.js

+  presets: [
+    ['@babel/preset-typescript'],
+    [
+      '@babel/preset-env',
+      {
+        targets: {node: 8},
+      },
+    ],
+  ],


Suggested change

presets: [

['@babel/preset-typescript'],

[

'@babel/preset-env',

{

targets: {node: 8},

},

],

],

presets: [

['@babel/preset-env', {targets: {node: 'current'}}],

'@babel/preset-typescript',

],

SimenB · 2020-11-15T12:50:54Z

e2e/transform/transform-testrunner/babel.config.js

+  presets: [
+    ['@babel/preset-typescript'],
+    [
+      '@babel/preset-env',
+      {
+        targets: {node: 8},
+      },
+    ],
+  ],


Suggested change

presets: [

['@babel/preset-typescript'],

[

'@babel/preset-env',

{

targets: {node: 8},

},

],

],

presets: [

['@babel/preset-env', {targets: {node: 'current'}}],

'@babel/preset-typescript',

],

SimenB · 2020-11-15T15:37:40Z

@Mark1626 this should be ready now?

Mark1626 · 2020-11-15T15:40:07Z

There is a e2e asyncRegenerator failing after the rebase, looking into it

Mark1626 · 2020-11-15T16:12:29Z

This is the failing test I'm trying to fix

e2e/__tests__/asyncRegenerator.test.ts

module.exports = {
  plugins: [
    '@babel/plugin-transform-regenerator',
    '@babel/plugin-transform-runtime',
  ],
  sourceType: 'script',
}

The @babel/plugin-transform-runtime should handle transforming the for of. I'm looking into it, thought I'd ask if this is something trivial I'm missing

Mark1626 · 2020-11-15T16:22:04Z

e2e/async-regenerator/package.json

+    "testEnvironment": "node",
+    "transformIgnorePatterns": [
+      "jest-jasmine2"
+    ]


@SimenB This was the reason the last test was failing. Adding it manually to transformIgnorePatterns, again as mentioned in a comment below these ignores are needed only when testing the jest repo, any consumers will not need to add these as these will be within node_modules

SimenB · 2020-11-15T16:51:23Z

packages/jest-runner/package.json

@@ -17,6 +17,7 @@
    "@jest/console": "^26.6.2",
    "@jest/environment": "^26.6.2",
    "@jest/test-result": "^26.6.2",
+    "@jest/transform": "^26.6.2",


Add to references in tsconfig

It's present in tsconfig.json.
Sorry this line should have been part of #8751 , got missed in the rebase I'll be more careful next time

https://github.com/facebook/jest/blob/68d68f5282bb11f93cc24ac41634667469138878/packages/jest-runner/tsconfig.json#L18

SimenB

👍

github-actions · 2021-05-11T00:07:11Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the cla signed label Aug 14, 2019

Mark1626 commented Aug 14, 2019

View reviewed changes

Mark1626 mentioned this pull request Aug 14, 2019

Support transforming all modules which can be specified in config #8810

Open

G-Rath reviewed Aug 15, 2019

View reviewed changes

e2e/transform/transform-testrunner/test-runner.ts Outdated Show resolved Hide resolved

G-Rath reviewed Aug 15, 2019

View reviewed changes

e2e/transform/transform-testrunner/test-runner.ts Outdated Show resolved Hide resolved

G-Rath mentioned this pull request Aug 15, 2019

Implement support for transforming snapshot resolvers #8829

Merged

SimenB reviewed Aug 15, 2019

View reviewed changes

e2e/transform/babel-jest-ignored/babel.config.js Outdated Show resolved Hide resolved

SimenB reviewed Aug 15, 2019

View reviewed changes

packages/jest-runner/package.json Outdated Show resolved Hide resolved

SimenB requested changes Aug 15, 2019

View reviewed changes

SimenB reviewed Aug 15, 2019

View reviewed changes

packages/jest-runner/tsconfig.json Outdated Show resolved Hide resolved

Mark1626 force-pushed the feature/transform-testrunner branch from df9a809 to b444350 Compare August 19, 2019 18:08

Mark1626 commented Aug 19, 2019

View reviewed changes

Mark1626 mentioned this pull request Aug 22, 2019

Add util to create empty testResult #8867

Merged

Mark1626 force-pushed the feature/transform-testrunner branch from c3f95da to 7caaa64 Compare August 22, 2019 17:11

Mark1626 force-pushed the feature/transform-testrunner branch 2 times, most recently from 4fe76fa to 87aaf3f Compare August 29, 2019 18:33

Mark1626 force-pushed the feature/transform-testrunner branch from 87aaf3f to 94e2a77 Compare September 13, 2019 08:16

Mark1626 force-pushed the feature/transform-testrunner branch from 94e2a77 to cd70978 Compare October 27, 2019 15:48

SimenB added this to the Jest 26 milestone Apr 28, 2020

cpojer removed this from the Jest 26 milestone May 2, 2020

cpojer added this to the High priority future milestone May 2, 2020

SimenB modified the milestones: High priority future, Jest 27 Oct 23, 2020

Mark1626 force-pushed the feature/transform-testrunner branch from ec32419 to 5069cef Compare November 15, 2020 04:45

Mark1626 commented Nov 15, 2020

View reviewed changes

SimenB reviewed Nov 15, 2020

View reviewed changes

Mark1626 added 2 commits November 15, 2020 21:12

feat: Allow testRunner to be configurable

d0077f8

chore: Review changes

2abf528

Mark1626 force-pushed the feature/transform-testrunner branch from fba4c35 to 2abf528 Compare November 15, 2020 16:10

fix: Fix failing test in async regenerator

34c2aec

Mark1626 commented Nov 15, 2020

View reviewed changes

chore: Reorder transformIgnorePattern

3beec27

SimenB reviewed Nov 15, 2020

View reviewed changes

fix: Add jest-circus to transformIgnorePattern

6d5e58c

SimenB approved these changes Nov 15, 2020

View reviewed changes

SimenB merged commit 0a0ac60 into jestjs:master Nov 15, 2020

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support transforming testRunner with preset/transform #8823

Support transforming testRunner with preset/transform #8823

Mark1626 commented Aug 14, 2019

Mark1626 Aug 14, 2019

Mark1626 Aug 14, 2019

SimenB Aug 15, 2019

SimenB Aug 15, 2019

SimenB left a comment

Mark1626 commented Aug 15, 2019

SimenB commented Aug 15, 2019

G-Rath commented Aug 18, 2019 •

edited

Loading

Mark1626 commented Aug 19, 2019

Mark1626 Aug 19, 2019

Mark1626 Aug 19, 2019

SimenB Aug 20, 2019

SimenB commented Aug 20, 2019

Mark1626 commented Aug 22, 2019 •

edited

Loading

Mark1626 commented Aug 25, 2019

SimenB commented Aug 25, 2019

Mark1626 commented Nov 15, 2020 •

edited

Loading

SimenB commented Nov 15, 2020

Mark1626 commented Nov 15, 2020

Mark1626 Nov 15, 2020

SimenB Nov 15, 2020

SimenB Nov 15, 2020

SimenB Nov 15, 2020

SimenB Nov 15, 2020

SimenB commented Nov 15, 2020

Mark1626 commented Nov 15, 2020

Mark1626 commented Nov 15, 2020

Mark1626 Nov 15, 2020

SimenB Nov 15, 2020

Mark1626 Nov 15, 2020

SimenB left a comment

github-actions bot commented May 11, 2021


		import {TestResult} from '@jest/test-result';

		export default function emptyTestResult(): TestResult {

Support transforming testRunner with preset/transform #8823

Support transforming testRunner with preset/transform #8823

Conversation

Mark1626 commented Aug 14, 2019

Summary

Test plan

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB left a comment

Choose a reason for hiding this comment

Mark1626 commented Aug 15, 2019

SimenB commented Aug 15, 2019

G-Rath commented Aug 18, 2019 • edited Loading

Mark1626 commented Aug 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB commented Aug 20, 2019

Mark1626 commented Aug 22, 2019 • edited Loading

Mark1626 commented Aug 25, 2019

SimenB commented Aug 25, 2019

Mark1626 commented Nov 15, 2020 • edited Loading

SimenB commented Nov 15, 2020

Mark1626 commented Nov 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB commented Nov 15, 2020

Mark1626 commented Nov 15, 2020

Mark1626 commented Nov 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB left a comment

Choose a reason for hiding this comment

github-actions bot commented May 11, 2021

G-Rath commented Aug 18, 2019 •

edited

Loading

Mark1626 commented Aug 22, 2019 •

edited

Loading

Mark1626 commented Nov 15, 2020 •

edited

Loading