Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade jsdom #8851

Merged
merged 3 commits into from
Aug 19, 2019
Merged

chore: upgrade jsdom #8851

merged 3 commits into from
Aug 19, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 19, 2019

Summary

Finally 🙂

Test plan

Green CI

SimenB
SimenB commented Aug 19, 2019
View reviewed changes
e2e/__tests__/config.test.ts
@@ -60,11 +60,11 @@ test('works with jsdom testEnvironmentOptions config JSON', () => {
'--config=' +
JSON.stringify({
testEnvironmentOptions: {
userAgent: 'Agent/007',
url: 'https://jestjs.io',
Copy link
Member Author

@SimenB SimenB Aug 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot set userAgent this way anymore. See jsdom/jsdom#2279

@SimenB SimenB merged commit dabba86 into jestjs:next Aug 19, 2019
@SimenB SimenB deleted the up-jsdom branch August 19, 2019 11:58
SimenB added a commit that referenced this pull request Aug 19, 2019
@SimenB
chore: upgrade jsdom (#8851)
a553e10
thymikee pushed a commit to SimenB/jest that referenced this pull request Aug 19, 2019
@SimenB @thymikee
chore: upgrade jsdom (jestjs#8851)
23be55f
SimenB added a commit that referenced this pull request Aug 21, 2019
@SimenB
chore: upgrade jsdom (#8851)
7e9b4ea
@kentcdodds
Copy link
Contributor

HOOOORAYYYY!!!!!!!!!!!!!!!!!!!

@kentcdodds
Copy link
Contributor

I noticed the next release was published. Does that mean Jest 25 (with these changes) is coming soon?

@SimenB
Copy link
Member Author

SimenB commented Aug 22, 2019

We were planning on making quite a few changes for Jest 25: https://github.com/facebook/jest/milestone/9

However, I wonder if just dropping node 6 and upgrading jsdom is a nice little major release that should be an easy upgrade for people, and we can make 26 be more breaking. Just dropping Node 6 (meaning we no longer transpile async-await) and upgrading micromatch reduced test time by ~10% on mac and linux and ~20% on windows for Jest's own tests, so it'd be awesome to get into people's hands.

Thoughts?

@kentcdodds
Copy link
Contributor

As a maintainer of a testing library that relies on jsdom, having the latest version would be really nice :)

SimenB added a commit that referenced this pull request Aug 22, 2019
@SimenB
chore: upgrade jsdom (#8851)
6d91d7c
SimenB added a commit that referenced this pull request Aug 22, 2019
@SimenB
chore: upgrade jsdom (#8851)
a7e75b4
@SimenB SimenB mentioned this pull request Aug 22, 2019
Closed
@eweap
Copy link

eweap commented Aug 22, 2019

Yeah ! A major version for node 6 drop and jsdom upgrade would be great !

@SimenB
Copy link
Member Author

SimenB commented Aug 22, 2019

You can install jest@next now. We'll be going for a smaller 25 as I talked about above - will be writing a short blog post tomorrow and it'll probably be latest tomorrow or early next week (friday deploys are... sketchy)

@SimenB
Copy link
Member Author

SimenB commented Aug 29, 2019

25 stable is currently a bit delayed due to issues rolling it out at FB (something with how they fake promises is broken). Hopefully they'll figure something out and we can proceed 🙂

@SimenB SimenB mentioned this pull request Sep 5, 2019
Merged
@ahnpnl
Copy link
Contributor

ahnpnl commented Sep 10, 2019

@thymikee does it mean jest-preset-angular can remove jest-environment-jsdom-thirteen after jest 25 rolls out ?

@thymikee
Copy link
Collaborator

@ahnpnl yes

@ranmocy ranmocy mentioned this pull request Sep 25, 2019
Closed
@ahnpnl ahnpnl mentioned this pull request Oct 3, 2019
Merged
@eps1lon eps1lon mentioned this pull request Oct 14, 2019
Merged
4 tasks
@wtho wtho mentioned this pull request Oct 15, 2019
Closed
This was referenced Jan 28, 2020
Open
Open
This was referenced Feb 4, 2020
Open
Open
Open
Open
This was referenced Feb 18, 2020
Open
Open
Open
@Leko Leko mentioned this pull request Feb 25, 2020
Open
This was referenced Mar 3, 2020
Open
Open
This was referenced Mar 10, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
This was referenced Mar 24, 2020
Open
Open
This was referenced Apr 16, 2020
Open
Open
Merged
Closed
Merged
This was referenced Apr 30, 2020
Closed
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SimenB @kentcdodds @eweap @ahnpnl @thymikee @facebook-github-bot