-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add util to create empty testResult #8867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Please rebase on master and add a changelog entry
It will go under as a |
Yup! |
Co-Authored-By: Simen Bekkhus <sbekkhus91@gmail.com>
0833d8e
to
270f5e4
Compare
@@ -6,7 +6,7 @@ | |||
*/ | |||
|
|||
import {Config} from '@jest/types'; | |||
import {AssertionResult, TestResult} from '@jest/test-result'; | |||
import {AssertionResult, TestResult, createEmptyTestResult} from '@jest/test-result'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier wants you to format this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I ran the lint with yarn lint:prettier
, not sure why it wasn't caught
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that only runs on md
files - you want yarn lint
which runs eslint that we've configured to use with prettier
Codecov Report
@@ Coverage Diff @@
## master #8867 +/- ##
=========================================
- Coverage 63.81% 63.8% -0.01%
=========================================
Files 274 274
Lines 11574 11575 +1
Branches 2838 2837 -1
=========================================
Hits 7386 7386
- Misses 3561 3562 +1
Partials 627 627
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Based on a suggestion in #8823
Creating an util in
@jest/test-result
which will create an emptyTestResult
/cc @SimenB
Test plan
Existing test cases should work after the change