Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest-config): merge preset globals with project globals #9027

Merged
merged 1 commit into from
Oct 26, 2019
Merged

feat(jest-config): merge preset globals with project globals #9027

merged 1 commit into from
Oct 26, 2019

Conversation

catfireparty
Copy link
Contributor

Summary

Resolves #9026

Test plan

Unit test "preset with globals" added to packages/jest-config/src/__tests__/normalize.test.js

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@catfireparty catfireparty force-pushed the merge-preset-globals branch 2 times, most recently from cc46dd2 to b5473ae Compare October 8, 2019 19:58
@catfireparty
Copy link
Contributor Author

I'm afraid I have no idea why test-node-12 is failing. That seems to have no relation to the code that I modified/added. 🤷

@thymikee
Copy link
Collaborator

thymikee commented Oct 8, 2019

It happens on other builds as well, don't worry about it for now

SimenB
SimenB approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project vs global is so confusing 🙁

@SimenB SimenB merged commit b096c16 into jestjs:master Oct 26, 2019
@catfireparty catfireparty mentioned this pull request Oct 28, 2019
Closed
@catfireparty catfireparty deleted the merge-preset-globals branch October 28, 2019 10:11
@catfireparty catfireparty mentioned this pull request Oct 28, 2019
Closed
@catfireparty catfireparty mentioned this pull request Nov 15, 2019
Closed
This was referenced Jan 28, 2020
Open
Open
This was referenced Feb 4, 2020
Open
Open
Open
Open
This was referenced Feb 18, 2020
Open
Open
Open
@Leko Leko mentioned this pull request Feb 25, 2020
Open
This was referenced Mar 3, 2020
Open
Open
This was referenced Mar 10, 2020
Open
Open
Open
@Leko Leko mentioned this pull request Mar 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
This was referenced Mar 24, 2020
Open
Open
This was referenced Apr 16, 2020
Open
Open
Merged
Closed
Merged
This was referenced Apr 30, 2020
Closed
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge preset globals with jest.config.js globals
4 participants
@catfireparty @facebook-github-bot @thymikee @SimenB