-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jest-utils: add a getter for process.domain #9136
Conversation
Fixes jestjs#7247: Explicitly copy domain to new process
Hi idan-at! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #9136 +/- ##
==========================================
- Coverage 64.83% 64.82% -0.02%
==========================================
Files 278 278
Lines 11732 11736 +4
Branches 2882 2884 +2
==========================================
+ Hits 7607 7608 +1
- Misses 3508 3510 +2
- Partials 617 618 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be an e2e test rather than unit test as we don't wanna mess with our own global env
Node 8 is not happy, could you take a look? |
@SimenB thanks for the quick reply! I'm on it, trying to find a non hacky way for solving it |
@SimenB done :) |
Thank you! |
Considering we drop support for Node 8, this compromise can be removed. jestjs#9136
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #7247
The reason of the change is that in node 12 process.domain is non-enumerable