-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make arguments to methods in base reporter optional #9159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #9159 +/- ##
=======================================
Coverage 64.83% 64.83%
=======================================
Files 278 278
Lines 11732 11732
Branches 2882 2883 +1
=======================================
Hits 7607 7607
Misses 3508 3508
Partials 617 617
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
If people extend the class they won't have to pass the arguments to please TS
Test plan
Green CI