Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support '.js', '.cjs', '.json' configs #9291

Merged
merged 8 commits into from
Dec 11, 2019

Conversation

the-spyke
Copy link
Contributor

Summary

Fixes #9086 and partially #9225. All 3 extensions are looked in order, allowed for manual specification with --config and supported for initialization in jest-cli.

Test plan

Try configuring Jest with all 3 supported config types: .js, .cjs, .json. Testing .cjs requires running Node >= 13.3.

@facebook-github-bot
Copy link
Contributor

Hi the-spyke! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #9291 into master will increase coverage by <.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9291      +/-   ##
==========================================
+ Coverage   64.98%   64.99%   +<.01%     
==========================================
  Files         278      278              
  Lines       11899    11912      +13     
  Branches     2934     2935       +1     
==========================================
+ Hits         7733     7742       +9     
- Misses       3537     3539       +2     
- Partials      629      631       +2
Impacted Files Coverage Δ
packages/jest-config/src/index.ts 11.76% <0%> (-0.18%) ⬇️
packages/jest-config/src/constants.ts 100% <100%> (ø) ⬆️
packages/jest-config/src/resolveConfigPath.ts 92% <100%> (+1.09%) ⬆️
packages/jest-cli/src/init/constants.ts 100% <100%> (ø) ⬆️
packages/jest-cli/src/init/index.ts 81.81% <83.33%> (-1.91%) ⬇️
packages/expect/src/utils.ts 94.93% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c8a69...edd08e1. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thank you! Could you add an e2e test using a cjs file? It can be skipped on nodes older than 13.2

packages/jest-cli/src/init/__tests__/init.test.js Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Dec 11, 2019

I just made the changes myself as they're minor. Thanks again for the PR! (will merge when/if green)

@the-spyke
Copy link
Contributor Author

@SimenB I was too late :-)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading .cjs config files on Node 13
5 participants