-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support '.js', '.cjs', '.json' configs #9291
Conversation
Hi the-spyke! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #9291 +/- ##
==========================================
+ Coverage 64.98% 64.99% +<.01%
==========================================
Files 278 278
Lines 11899 11912 +13
Branches 2934 2935 +1
==========================================
+ Hits 7733 7742 +9
- Misses 3537 3539 +2
- Partials 629 631 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful, thank you! Could you add an e2e test using a cjs file? It can be skipped on nodes older than 13.2
I just made the changes myself as they're minor. Thanks again for the PR! (will merge when/if green) |
@SimenB I was too late :-) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #9086 and partially #9225. All 3 extensions are looked in order, allowed for manual specification with
--config
and supported for initialization injest-cli
.Test plan
Try configuring Jest with all 3 supported config types:
.js
,.cjs
,.json
. Testing.cjs
requires runningNode >= 13.3
.