Resolve dynamic dependencies correctly when a mapping exists

[MrJohz]

Summary

Fix #7511

When resolving a dynamic dependency (e.g. require(`~/${dynamicName}.js`), handle the case where there is a dependency resolution mapping correctly. Do this by catching all errors during the module resolution process, and not adding a new dependency is the would-be dependency cannot be resolved to a real module.

Test plan

I added an additional e2e test that reproduces the failing case. (Thanks to @jeysal for their previous attempt to isolate the cause.) I didn't add additional unit tests for this because I felt it would complicate matters, and figured that the e2e test covered the case entirely.

[codecov-io]

Codecov Report

Merging #9303 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9303      +/-   ##
==========================================
+ Coverage   64.99%   65.01%   +0.01%     
==========================================
  Files         278      278              
  Lines       11912    11913       +1     
  Branches     2934     2935       +1     
==========================================
+ Hits         7742     7745       +3     
+ Misses       3539     3538       -1     
+ Partials      631      630       -1

Impacted Files	Coverage Δ
packages/jest-resolve-dependencies/src/index.ts	94% <100%> (+4.2%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446d174...5bc89d9. Read the comment docs.

[jeysal]

Thanks, tested against https://github.com/jeysal/jest-7511-repro and looks like it works! :)

[SimenB]

I think a unit test makes sense here in addition to the e2e test

[MrJohz]

I think a unit test makes sense here in addition to the e2e test

@SimenB, I'm trying to write a unit test, but for some reason I can't get the unit tests to actually run. Running yarn jest in the jest-resolve-dependencies directory fails because it's operating on the TS sources without babelification, so jest throws a SyntaxError when it hits the first type annotation. Running yarn test in the root directory doesn't seem to find any of the tests in the individual packages.

Am I missing something here in trying to run the tests?

[SimenB]

You should run ./jest (or yarn jest) from the root of the repo. Running with watch mode should ensure you only run the subset of tests for the files you change

[MrJohz]

@SimenB + others - I've added the unit test

[SimenB]

Wonderful, thank you!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.