Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pattern of replacePosixSep is a string #9546

Merged
merged 4 commits into from
Feb 12, 2020

Conversation

luann112
Copy link
Contributor

Summary

Fix #9526 (comment)

  • the pattern of replacePosixSep should be string type

@facebook-github-bot
Copy link
Contributor

Hi @luann112!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@drew-gross
Copy link

drew-gross commented Feb 10, 2020

Codecov Report

Merging #9546 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9546   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files         286      286           
  Lines       12123    12123           
  Branches     3004     3004           
=======================================
  Hits         7885     7885           
  Misses       3600     3600           
  Partials      638      638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfbcda...13460a2. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you add a test as well? An integration test makes sense to me here

@luann112 luann112 force-pushed the fix-replacePosixSep branch from 13460a2 to 8358499 Compare February 12, 2020 14:39
@luann112
Copy link
Contributor Author

Thank you! Could you add a test as well? An integration test makes sense to me here

Sorry for not able to reply back to you sooner. Thanks for your support anyway.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest crashes on Windows if regexForTestFiles provided from cli is a number
4 participants