Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moduleNameMapper should take precedence over Node core modules #9563

Merged
merged 6 commits into from
Feb 12, 2020
Merged

fix: moduleNameMapper should take precedence over Node core modules #9563

merged 6 commits into from
Feb 12, 2020

Conversation

lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented Feb 11, 2020 •
edited
Loading

Summary

Resolved #8610

Test plan

Green Ci, write more test for new code.

@lh0x00 lh0x00 requested review from SimenB and jeysal February 11, 2020 20:15
SimenB
SimenB approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

packages/jest-resolve/src/index.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@lh0x00 lh0x00 force-pushed the bugfix/UpdateIsCoreModuleHelper branch from b89e4d2 to edb25ff Compare February 12, 2020 02:37
@codecov-io
Copy link

codecov-io commented Feb 12, 2020 •
edited
Loading

Codecov Report

Merging #9563 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9563      +/-   ##
==========================================
+ Coverage   65.05%   65.07%   +0.01%     
==========================================
  Files         286      286              
  Lines       12123    12128       +5     
  Branches     3004     3005       +1     
==========================================
+ Hits         7887     7892       +5     
  Misses       3599     3599              
  Partials      637      637
Impacted Files Coverage Δ
packages/jest-resolve/src/index.ts 47.71% <100%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e3992...5b11dfb. Read the comment docs.

@lh0x00
Copy link
Contributor Author

lh0x00 commented Feb 12, 2020

hi @SimenB , I updated PR and it ready to merge!

@SimenB SimenB changed the title Bugfix/UpdateIsCoreModuleHelper fix: moduleNameMapper should take precedence over Node core modules Feb 12, 2020
@SimenB SimenB merged commit 2793c67 into jestjs:master Feb 12, 2020
@SimenB
Copy link
Member

SimenB commented Feb 12, 2020

Thanks @lamhieu-vk!

@lh0x00
Copy link
Contributor Author

lh0x00 commented Feb 12, 2020

Thanks @SimenB , 😱 but... I seem you work on GitHub all day?

This was referenced Apr 16, 2020
Open
Open
Merged
Closed
Merged
This was referenced Apr 25, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@jeysal jeysal Awaiting requested review from jeysal

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

moduleNameMapper does not work with constants
4 participants
@lh0x00 @codecov-io @SimenB @facebook-github-bot